Fix formatting of plain text items #236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to preserve whitespace in RSS/ATOM item descriptions.
Also fix flipped expected/actual arguments.
Shinokuni
reviewed
Dec 12, 2024
Member
|
Hello, thank you for this contribution! I've added a comment about Knowing if item content is plain text might add a bit of overhead for large text, but it should be ok. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check whether body actually has any HTML markup, and if not then treat item's text as plain text and convert it to HTML by turning newline characters and empty lines in
<br>/<p>tags (usingHtmlCompat.toHtml()method).Here is an example of feed that's currently displayed incorrectly: https://lists.opensuse.org/archives/list/factory@lists.opensuse.org/feed/