Customize shared text using template setting

[christophehenry]

Implement #251

[Shinokuni]

Hello, thank you for this! I'm sorry for not answering your issue before you started working on this. So let's see.

I got a bit of a hard time making the template to work, due to a few things:

• I took the textfield placeholder in CustomShareIntentTextWidget as the proper template and thus I didn't understand why it wouldn't work when I saved it and clicked on the share buttons. I think the placeholder should be real text, firstly to avoid confusion from users and secondly to let them work and modify a already working template
• When you launch the app with the template parameter disabled, if you enable it and go back to the timeline tab, the template won't work because you get it only once at launch with customShareIntentTpl = preferences.customShareIntentTpl.flow.first(). You won't be able to react to its changes. This should go in getTimelinePreferences

Otherwise it works greatly, I would have a few other things to say:

• When sharing with the template activated for the first time, it takes a significant amount of time before the android share dialog shows up. Is it due to the PebbleEngine engine building? Are you able to reproduce this?
• When sharing from the timeline list, the author variable isn't available. We need it to get it from the database
• Could you add a french translation? Otherwise I can handle it myself

[christophehenry]

Is it due to the PebbleEngine engine building? Are you able to reproduce this?

I believe so because it seems to be doing a lot of introspection and since it's static, it seems to happen only the first time. I don't know what to do about it. Maybe a Koin injection? I'm not sure whether Koin modules are lazy or not.

Edit: So I just tested and, yes, they're lazy. Except for importing ShareIntentTextRenderer in ReadropsApp to force instanciation of the static variable, I don't know what to do.

Could you add a french translation? Otherwise I can handle it myself

Yes, I will do. Please remind me to do so if I forget.

I will try to fix your other comments tomorrow.

[christophehenry]

I think I fixed everything except for the latency due to the PebbleEngine initialization.

I think the placeholder should be real text

I added a button to fill the input with a default template. I updated the images in the description of the PR according to that.

[christophehenry]

I fixed the R8 compilation error with the last commit.

When sharing with the template activated for the first time, it takes a significant amount of time before the android share dialog shows up.

This does not seem to reproduce with the beta and release builds so I guess it's fine. The compiler must be optimizing the code.

[codecov]

Codecov Report

Attention: Patch coverage is 8.33333% with 176 lines in your changes missing coverage. Please review.

Project coverage is 19.77%. Comparing base (15eb463) to head (026eb2b).

Files with missing lines	Patch %	Lines
...ferences/components/CustomShareIntentTextWidget.kt	0.00%	86 Missing ⚠️
...a/com/readrops/app/util/ShareIntentTextRenderer.kt	18.75%	26 Missing ⚠️
...ops/app/more/preferences/PreferencesScreenModel.kt	0.00%	18 Missing ⚠️
app/src/main/java/com/readrops/app/util/Utils.kt	0.00%	12 Missing ⚠️
...readrops/app/more/preferences/PreferencesScreen.kt	0.00%	11 Missing ⚠️
...main/java/com/readrops/app/item/ItemScreenModel.kt	0.00%	8 Missing ⚠️
...e/preferences/components/SwitchPreferenceWidget.kt	0.00%	8 Missing ⚠️
...a/com/readrops/app/timelime/TimelineScreenModel.kt	0.00%	7 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #254      +/-   ##
=============================================
- Coverage      19.94%   19.77%   -0.17%     
  Complexity       448      448              
=============================================
  Files            188      190       +2     
  Lines           9838     9998     +160     
  Branches        1545     1563      +18     
=============================================
+ Hits            1962     1977      +15     
- Misses          7760     7905     +145     
  Partials         116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[christophehenry]

Uh. You want me to add integration tests? Can do but I really hate writing android tests.

[Shinokuni]

I don't think we need KoinComponent anymore, don't we?

[christophehenry]

Alright, the last commit applies your suggestions.

[Shinokuni]

Thank you for this work! I hope to be able to release a new version soon with this, most of the work has been done.

[christophehenry]

Awesome! Thank you!