Fix gap above bottom navigation bar

[equeim]

No description provided.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 19.93%. Comparing base (15eb463) to head (1266421).
Report is 2 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../src/main/java/com/readrops/app/home/HomeScreen.kt	0.00%	5 Missing ⚠️

Additional details and impacted files

@@              Coverage Diff              @@
##             develop     #266      +/-   ##
=============================================
- Coverage      19.94%   19.93%   -0.01%     
  Complexity       448      448              
=============================================
  Files            188      188              
  Lines           9838     9842       +4     
  Branches        1545     1546       +1     
=============================================
  Hits            1962     1962              
- Misses          7760     7764       +4     
  Partials         116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Shinokuni]

Thanks for this! I suppose you stumbled on this while working on develop right?

[equeim]

Thanks for this! I suppose you stumbled on this while working on develop right?

Yep, I wanted to make article screen edge-to-edge (so that WebView is rendered underneath navigation bar / gesture bar). I will make a PR for that soon if you are not against this feature.

[Shinokuni]

What kind of edge-to edge are we talking here? Readrops currently uses enableEdgeToEdge() to perform it globally. Is is when the navigation bar is displayed instead of the gesture bar?

[equeim]

What kind of edge-to edge are we talking here? Readrops currently uses enableEdgeToEdge() to perform it globally. Is is when the navigation bar is displayed instead of the gesture bar?

Currently when you scroll down (to hide bottom bar) the article's content is cut off at the edge of the navigation bar:

With that change the navigation bar will be semi transparent (or fully transparent in case of thin gesture bar) and the content will be underneath it (that what Google really means by "edge to edge"):

[Shinokuni]

Okay thank you, this is more clear to me now.

This is something I've been thinking about when I worked on making Readrops edge to edge. What bothers me is the screen bottom bar which disappears on scroll down. Having the bottom bar displayed above a transparent navigation bar seemed odd to me. What do you think about this?