Skip to content

Conversation

@christophehenry
Copy link
Contributor

@christophehenry christophehenry commented Feb 13, 2025

  • Add french typography filter
  • Improve share intent template dialog by making it scrollable and explantations on each filter more readable.

@christophehenry christophehenry marked this pull request as ready for review February 13, 2025 13:38
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 5.12821% with 37 lines in your changes missing coverage. Please review.

Project coverage is 19.72%. Comparing base (9df5ca1) to head (771553d).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
...a/com/readrops/app/util/ShareIntentTextRenderer.kt 6.89% 27 Missing ⚠️
...ferences/components/RadioButtonPreferenceDialog.kt 0.00% 5 Missing ⚠️
...ferences/components/CustomShareIntentTextWidget.kt 0.00% 4 Missing ⚠️
app/src/main/java/com/readrops/app/MainActivity.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #269      +/-   ##
=============================================
- Coverage      19.77%   19.72%   -0.05%     
  Complexity       448      448              
=============================================
  Files            190      190              
  Lines          10002    10032      +30     
  Branches        1564     1565       +1     
=============================================
+ Hits            1978     1979       +1     
- Misses          7908     7937      +29     
  Partials         116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@christophehenry christophehenry force-pushed the template-french-typo branch 3 times, most recently from d7a7248 to 0dd7865 Compare February 13, 2025 15:21
@Shinokuni
Copy link
Member

LGTM, thanks!

@Shinokuni Shinokuni merged commit 3dca0dd into readrops:develop Feb 15, 2025
1 check passed
@christophehenry christophehenry deleted the template-french-typo branch February 15, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants