Skip to content

Conversation

@equeim
Copy link
Contributor

@equeim equeim commented Feb 13, 2025

By default ComposeView has transparent background and black text. In order to use colors from MaterialTheme we need to use either Scaffold or Surface, or set them manually using CompositionLocalProvider. Fix colors in More tab by wrapping it in Surface.

By default ComposeView has transparent background and black text.
In order to use colors from MaterialTheme we need to use either Scaffold or Surface, or set them manually using CompositionLocalProvider.
Fix colors in More tab by wrapping it in Surface.
@codecov
Copy link

codecov bot commented Feb 13, 2025

Codecov Report

Attention: Patch coverage is 0% with 88 lines in your changes missing coverage. Please review.

Project coverage is 19.76%. Comparing base (9df5ca1) to head (8e2c3c3).
Report is 1 commits behind head on develop.

Files with missing lines Patch % Lines
app/src/main/java/com/readrops/app/more/MoreTab.kt 0.00% 88 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #270      +/-   ##
=============================================
- Coverage      19.77%   19.76%   -0.02%     
  Complexity       448      448              
=============================================
  Files            190      190              
  Lines          10002    10005       +3     
  Branches        1564     1566       +2     
=============================================
- Hits            1978     1977       -1     
- Misses          7908     7912       +4     
  Partials         116      116              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shinokuni
Copy link
Member

I wonder what would be the best choice here, Scaffold or Surface? Surface is good enough, but all other tabs use Scaffold. What do you think?

@equeim
Copy link
Contributor Author

equeim commented Feb 14, 2025

I wonder what would be the best choice here, Scaffold or Surface? Surface is good enough, but all other tabs use Scaffold. What do you think?

Well, Scaffold's purpose is to provide a "template" for a typical screen with top/bottom bars, FAB, etc. For simple screens that don't have that Surface is enough. There is no difference in behaviour and I see no reason to not use the simplest solution. If this screen will need Scaffold's features it would be trivial to rewrite it.

@Shinokuni
Copy link
Member

All right, let's go with this, thanks!

@Shinokuni Shinokuni merged commit 1dfe26c into readrops:develop Feb 15, 2025
1 check passed
@equeim equeim deleted the fix-more-tab-colors branch February 15, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants