Skip to content

Conversation

@christophehenry
Copy link
Contributor

First known special case is Youtube playlists for which RSS feed exists but is not published in a <link>.

@codecov
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 38.46154% with 8 lines in your changes missing coverage. Please review.

Project coverage is 19.65%. Comparing base (3a014f6) to head (25ab4ea).
Report is 5 commits behind head on develop.

Files with missing lines Patch % Lines
...m/readrops/app/feeds/newfeed/NewFeedScreenModel.kt 0.00% 4 Missing ⚠️
...i/src/main/java/com/readrops/api/utils/ApiUtils.kt 71.42% 0 Missing and 2 partials ⚠️
...va/com/readrops/app/feeds/newfeed/NewFeedScreen.kt 0.00% 2 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #272      +/-   ##
=============================================
+ Coverage      19.62%   19.65%   +0.03%     
- Complexity       450      454       +4     
=============================================
  Files            190      190              
  Lines          10089    10097       +8     
  Branches        1576     1578       +2     
=============================================
+ Hits            1980     1985       +5     
- Misses          7990     7991       +1     
- Partials         119      121       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shinokuni
Copy link
Member

Oh okay, this is indeed a very special case! LGTM apart that youtube url/playlist checking should be unit tested. Could you extract it in api/utils and provide some tests?

@christophehenry
Copy link
Contributor Author

Done!

@Shinokuni
Copy link
Member

Nice, thanks for this!

@Shinokuni Shinokuni merged commit 32fe420 into readrops:develop Feb 19, 2025
1 check passed
@christophehenry christophehenry deleted the youtube-playlist-rss branch February 19, 2025 17:37
@christophehenry
Copy link
Contributor Author

Awesome! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants