Fix HTML parsing #273
Merged
Fix HTML parsing #273
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OkHttp already parses it into MediaType object, make use of it.
use {} already takes care of that.
HTML tags can be capitalized.
…encodings charStream() function creates Reader with charset from Content-Type header (if system supports it).
equeim
force-pushed
the
fix-html-parsing
branch
from
0635bee to
0e5d682
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
=============================================
- Coverage 19.77% 19.70% -0.08%
- Complexity 448 450 +2
=============================================
Files 190 190
Lines 10002 9998 -4
Branches 1564 1564
=============================================
- Hits 1978 1970 -8
- Misses 7908 7909 +1
- Partials 116 119 +3 ☔ View full report in Codecov by Sentry. |
Member
|
LGTM, also thanks for the tests! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mainly does 2 things:
<head>tag case-insensitive since HTML tags are not guaranteed to be in lower caseResponseBody.charStream()which automatically handlescharsetparameter inContent-Typeheader.Also removes unnecessary
close()calls.