Skip to content

Conversation

@christophehenry
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 26 lines in your changes missing coverage. Please review.

Project coverage is 19.62%. Comparing base (32fe420) to head (95fa876).
Report is 7 commits behind head on develop.

Files with missing lines Patch % Lines
...count/credentials/AccountCredentialsScreenModel.kt 0.00% 25 Missing ⚠️
app/src/main/java/com/readrops/app/AppModule.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #275      +/-   ##
=============================================
- Coverage      19.64%   19.62%   -0.03%     
  Complexity       456      456              
=============================================
  Files            190      190              
  Lines          10100    10126      +26     
  Branches        1581     1582       +1     
=============================================
+ Hits            1984     1987       +3     
- Misses          7996     8019      +23     
  Partials         120      120              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Shinokuni
Copy link
Member

Wow thanks for this! I've been looking for a way like this to enable faster login during development for years now, but I've always felt you had to be a Gradle wizard to achieve something like that.

Now I have an observation. This way to inject credentials is currently not aware of the account context. Credentials are applied without consideration for the account type. Could you add a way to declare credentials for all account types (something like freshrss.url, fever.password) and use the right ones in AccountCredentialsScreen?

@christophehenry
Copy link
Contributor Author

lord-of-the-rings-i-could-do-that

@christophehenry
Copy link
Contributor Author

Done.

login = context.getString(R.string.debug_greader_login),
password = context.getString(R.string.debug_greader_password),
)
null -> AccountCredentialsState(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This block is the same as AccountType.LOCAL. Could you merge them?

@Shinokuni
Copy link
Member

Wow perfect! Also thanks for the doc in the README, it will come in handy to new contributors. There is only one review to solve and we are good to go.

@christophehenry
Copy link
Contributor Author

Sure! Done.

@Shinokuni Shinokuni merged commit d7205c5 into readrops:develop Feb 24, 2025
1 check passed
@Shinokuni
Copy link
Member

Thanks for this, I will be really helpful!

@christophehenry christophehenry deleted the develop-credentials branch February 24, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants