-
-
Notifications
You must be signed in to change notification settings - Fork 31
Allow sourcing account credentials from local.properties during development #275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow sourcing account credentials from local.properties during development #275
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #275 +/- ##
=============================================
- Coverage 19.64% 19.62% -0.03%
Complexity 456 456
=============================================
Files 190 190
Lines 10100 10126 +26
Branches 1581 1582 +1
=============================================
+ Hits 1984 1987 +3
- Misses 7996 8019 +23
Partials 120 120 ☔ View full report in Codecov by Sentry. |
|
Wow thanks for this! I've been looking for a way like this to enable faster login during development for years now, but I've always felt you had to be a Gradle wizard to achieve something like that. Now I have an observation. This way to inject credentials is currently not aware of the account context. Credentials are applied without consideration for the account type. Could you add a way to declare credentials for all account types (something like |
f44d4ad to
0268b92
Compare
|
Done. |
| login = context.getString(R.string.debug_greader_login), | ||
| password = context.getString(R.string.debug_greader_password), | ||
| ) | ||
| null -> AccountCredentialsState( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is the same as AccountType.LOCAL. Could you merge them?
|
Wow perfect! Also thanks for the doc in the README, it will come in handy to new contributors. There is only one review to solve and we are good to go. |
0268b92 to
95fa876
Compare
|
Sure! Done. |
|
Thanks for this, I will be really helpful! |

No description provided.