Add new static_over_final_class rule#5487
Merged
SimplyDanny merged 4 commits intorealm:mainfrom Mar 8, 2024
Merged
Conversation
04c2b15 to
1b189e0
Compare
SimplyDanny
requested changes
Mar 6, 2024
Collaborator
SimplyDanny
left a comment
There was a problem hiding this comment.
Thank you for the contribution. A few remarks ...
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/FinalClassRule.swift
Outdated
Show resolved
Hide resolved
Collaborator
|
Run |
1b189e0 to
4aa6ada
Compare
final_class rulestatic_over_final_class rule
Contributor
Author
|
@SimplyDanny thanks for the review! I have pushed changes to address all comments, and also noted a question here if you have time to explain your approach to me. If you are happy with the contents of the PR, I will squash the commits and update the PR to clean up the history. |
SimplyDanny
requested changes
Mar 7, 2024
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Source/SwiftLintBuiltInRules/Rules/Idiomatic/StaticOverFinalClassRule.swift
Outdated
Show resolved
Hide resolved
Collaborator
Manual squashing is not necessary. That's done by GitHub when merging. |
Co-authored-by: Danny Mösch <danny.moesch@icloud.com>
SimplyDanny
approved these changes
Mar 8, 2024
kohtenko
pushed a commit
to kohtenko/SwiftLint
that referenced
this pull request
Mar 8, 2024
jamesonwilliams
referenced
this pull request
in Whatnot-Inc/SwiftLint
Aug 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements rule requested in #5471