Code review #5
Closed
Code review #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 2, 2014 13:07
…ng everything in the application delegate
…nd simply create and show the window at launch.
…`-windowDidLoad:`
This is to make sure that users can reopen the window when clicking the Dock icon if they inadvertently closed it.
We rather trust LaunchServices and query `NSWorkspace` for the “Application Loader” application path. If found, we can retrieve the iTMSTransporter binary path.
… compilation unit.
Update the UI on the main thread before enqueuing the operation on a background queue. Similarly, create a new operation enqueued on the main queue to update the UI and make it dependent on the task operation. These 3 methods are also begging for refactoring.
Each of the 3 methods now calls into a private method doing the actual work.
… of the controls.
Remove outlets and delegates, welcome to the world of AppKit!
The status is now dependent on the credentials validity and the internal status.
added 20 commits
February 2, 2014 15:24
This ensures that we don’t do synchronous I/O by calling `-readDataToEndOfFile` on the standard output `NSFileHandle`.
Set the window controller as delegate. Attempt to find credentials in the keychain when loading the window. Attempt to find credentials in the keychain anytime the username text field ends editing and the password text field is empty. Save the last username that was used so that we can query the right account from the keychain on next launch.
… annoying when accessing the keychain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See my code review and changes I’d make to it before shipping.