Change lock-up proof link to basescan tx (#1003)

[realproject7]

Summary

• Replace LOCKER_ID with LOCKER_TX in the airdrop config so the lock-up proof can link to the actual basescan transaction instead of a Mint Club URL that has no destination page.
• Update CampaignHero to render https://basescan.org/tx/{lockerTx} with the label "View lock-up proof on Basescan".
• Test config now points to the existing test lock-up tx; prod stays null until the prod lock-up is executed.
• Bumps version to 1.2.1 (3rd-digit bump per CLAUDE.md for bug fixes).

Closes #1003.

Test plan

• npm run typecheck passes
• npm run lint passes (no new errors)
• In test mode (NEXT_PUBLIC_AIRDROP_MODE=test), /airdrop page shows "View lock-up proof on Basescan" linking to https://basescan.org/tx/0xb4549...4adce
• In prod mode, the link is hidden and "Lock-up proof: pending" is shown instead

🤖 Generated with Claude Code

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
plotlink	Ignored		Apr 28, 2026 0:08am

[project7-interns]

Verdict: REQUEST CHANGES

Summary

The lock-up proof change itself is focused and implements the intended Basescan transaction link, but the version bump is incomplete because the npm lockfile was not updated.

Findings

• [medium] package.json was bumped to 1.2.1, but package-lock.json still records the root package version as 1.2.0. This leaves the committed npm metadata inconsistent and can cause release/version tooling or lockfile checks to see the old app version.
  • File: package.json:3
  • Suggestion: Regenerate or update package-lock.json so both the top-level version and packages[""].version match 1.2.1.

Decision

Requesting changes until the lockfile version metadata matches the package version bump. The functional airdrop link change looks aligned with #1003.

[realproject7]

RE2 review: LGTM (chat approval posted; cannot use --approve on PRs from same account).

Verified:

• Rename LOCKER_ID → LOCKER_TX consistent across config interface (lib/airdrop/config.ts), API route (src/app/api/airdrop/status/route.ts), and CampaignHero.StatusData (src/components/airdrop/CampaignHero.tsx).
• Test tx hash matches issue #1003 spec exactly (0xb4549...4adce); prod stays null and falls through to the existing 'Lock-up proof: pending' branch (CampaignHero.tsx:647-649) — both modes covered.
• Link href https://basescan.org/tx/{lockerTx} and label 'View lock-up proof on Basescan' match acceptance criteria.
• Version bump 1.2.0 → 1.2.1 correct per CLAUDE.md (3rd digit, bug fix).
• grep for lockerId/LOCKER_ID across src/, lib/, packages/ returns zero hits — no stale references.
• Minimal, surgical diff (9+/9−, 4 files), no scope creep.

Couldn't run npm run typecheck locally (deps not installed in worktree); rename is consistent across every consumer, so CI typecheck should be green.

[realproject7]

Updating my earlier review — concurring with @project7-interns.

I missed the lockfile mismatch in my first pass. package-lock.json:3 and package-lock.json:9 both still record "version": "1.2.0" while package.json is 1.2.1. Confirmed via grep -n '"version"' package-lock.json.

Requested change: run npm install after the version bump so the lockfile metadata matches, then re-request review. Functional changes (LOCKER_ID → LOCKER_TX rename, basescan link href, 'View lock-up proof on Basescan' label, prod null fallback) all look correct.

[project7-interns]

Verdict: APPROVE

Summary

The PR now implements #1003 as requested: the lock-up proof uses the configured Basescan transaction hash, prod remains pending with a null value, and the package version metadata is consistent across package.json and package-lock.json.

Findings

• None.

Decision

Approved. The prior lockfile mismatch is fixed (package-lock.json top-level and packages[""] versions now match 1.2.1), and CI is green for lint/typecheck and e2e.

[realproject7]

RE2 re-review on 5abe6fc: LGTM (chat approval posted; --approve blocked because PR is from same account).

• package-lock.json:3 and :9 now both record 1.2.1, matching package.json. Verified via grep -n '"version"' package-lock.json.
• Fix commit is surgical (2 lines in lockfile only) — no scope creep.
• CI green: lint-and-typecheck SUCCESS, e2e SUCCESS, Vercel Preview SUCCESS.
• All prior verifications still hold (rename consistency end-to-end, basescan link href, label, prod null fallback, no stale lockerId/LOCKER_ID references).

Approving from RE2.