[#1017] Hide CMC rank references in test mode#1021
Merged
realproject7 merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
CMC ranks (≈ CMC #1900, etc.) are tied to prod FDV targets and meaningless alongside test-mode values ($7K–$50K). Conditional on AIRDROP_TEST_MODE so they only render in prod. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
commented
Apr 30, 2026
Owner
Author
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 — APPROVE
Clean, minimal fix. AIRDROP_TEST_MODE is correctly derived from the existing mode variable and reused for config selection. The conditional null in buildMilestoneRows is the right approach — no UI-layer hacks needed. Prod path unchanged. No concerns.
project7-interns
approved these changes
Apr 30, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #1017 and keeps the fix narrowly scoped: test mode suppresses the static CMC rank labels while prod mode keeps the existing labels.
Findings
- No code findings.
- CI note:
e2eandlint-and-typecheckwere still pending at review time.
Decision
Approved because the behavior change is correct, minimal, and aligned with the acceptance criteria. Final merge should still wait for the required checks to finish successfully.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1017
Summary
AIRDROP_TEST_MODEfromlib/airdrop/config.tsfor client-side test/prod detectionCampaignHero.tsx, conditionally null outcmcRankwhen in test mode so "≈ CMC #X" labels don't render alongside tiny test FDV values ($7K–$50K)Test plan
NEXT_PUBLIC_AIRDROP_MODE=test→ verify milestone rows show no CMC rank textNEXT_PUBLIC_AIRDROP_MODE=prod(or unset) → verify CMC ranks display next to each FDV milestone🤖 Generated with Claude Code