[#1018] Rename FDV → MCap across airdrop UI#1023
Conversation
Display-only change: all user-facing "FDV" labels replaced with "MCap". Added footnote in CampaignHero: "MCap = PLOT price × 1M max supply". Internal variable names (currentFdv, mcap in config) unchanged. Files changed: - CampaignHero.tsx: burn bar label, milestone rows, footnote - UserPoints.tsx: estimated airdrop tooltips - WeeklySnapshots.tsx: weekly snapshot label Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR matches issue #1018 and keeps the change display-only: user-facing FDV labels are renamed to MCap, the explanatory footnote is added, and internal variable/API names remain unchanged.
Findings
- No code findings.
- CI note:
e2eandlint-and-typecheckwere still pending at review time.
Decision
Approved because the implementation is scoped correctly, aligns with the acceptance criteria, and I did not find remaining airdrop FDV labels in the reviewed UI paths.
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 — REQUEST CHANGES
The 3 files touched are correct, but several user-facing "FDV" labels remain in CampaignHero.tsx and MilestoneTrack.tsx (untouched):
CampaignHero.tsx (missed):
- L417:
FDV (USD)— y-axis label - L487:
Actual FDV— chart legend - L500:
FDV Progress— section heading - L632:
If PLOT FDV reaches milestone targets...— description text
MilestoneTrack.tsx (not touched at all):
- L164:
FDV Milestone Chart— heading - L167:
Pool unlock curve across FDV milestones · FDV = PLOT price— description - L297:
FDV →— axis label - L401:
Current FDV:— label - L408:
...FDV— milestone label
Issue acceptance criteria: "All user-facing FDV replaced with MCap." These are all rendered text, not internal variable names. Please update.
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 — UPDATE: APPROVE
My earlier findings were incorrect — I was grepping main, not the PR branch. On the actual branch:
MilestoneTrack.tsxwas deleted in #1011 — those references don't existCampaignHero.tsxhas zero remaining user-facing FDV strings
All user-facing FDV → MCap correctly. Apologies for the false flag. No issues.
2 participants
Fixes #1018
Summary
currentFdv,mcapin config) left unchanged — display-only changeFiles changed
CampaignHero.tsx— burn bar "Current MCap", milestone rows "MCap $X", footnoteUserPoints.tsx— "At $X MCap →" and "(based on current MCap)"WeeklySnapshots.tsx— "MCap:" labelTest plan
currentFdvstill used internally🤖 Generated with Claude Code