Move innovation comparison to modal from hero (#1029)#1033
Move innovation comparison to modal from hero (#1029)#1033realproject7 merged 2 commits intomainfrom
Conversation
Add "Why is this airdrop different?" link in the hero that opens a modal with the two-column comparison (Typical vs This Airdrop) and summary text. Remove the inline InnovationBanner from the page layout. Modal closes on backdrop click or X button. Bump version: 1.3.3 → 1.4.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR implements issue #1029 cleanly: the hero now has a "Why is this airdrop different?" trigger, clicking it opens a modal with the existing comparison content, and the standalone InnovationBanner placement is removed from the airdrop page.
Findings
- [ok] Hero includes the requested modal trigger link.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Modal contains the prior two-column comparison and summary content, and supports close button plus backdrop click dismissal.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Inline standalone
InnovationBannersection was removed from the page layout.- File:
src/app/airdrop/page.tsx
- File:
- [ok] Branch is mergeable and checks passed:
lint-and-typecheck,e2e, Vercel.- File: PR checks
Decision
Approve. The change is focused, matches #1029 acceptance criteria, and passes CI.
realproject7
left a comment
There was a problem hiding this comment.
RE2 Verdict: APPROVE (with minor nit)
Summary
Clean implementation of #1029. Modal trigger in hero, comparison content in modal, InnovationBanner removed from page layout. Modal has backdrop close, X button, and stopPropagation on content. Version bump 1.3.3 → 1.4.0 appropriate for feature work.
Findings
- [ok] "Why is this airdrop different? →" link placed between headline and countdown — matches wireframe.
- [ok] Modal content matches spec: two-column comparison (Typical vs This), summary paragraph.
- [ok] Modal closes on backdrop click and X button; content click doesn't close (stopPropagation).
- [ok] InnovationBanner import and usage removed from
airdrop/page.tsx. - [ok] Responsive:
grid-cols-1 sm:grid-cols-2for modal columns. - [ok] Version bump 1.3.3 → 1.4.0 correct for feature.
- [ok] Mergeable.
- [nit]
InnovationBanner.tsxis now orphaned (no imports anywhere). Could be deleted in this PR or a follow-up — not blocking.
Decision
Approve. LGTM.
Content now lives in the CampaignHero modal; no remaining imports. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
Re-reviewed after the follow-up commit. The added commit only deletes the now-orphaned InnovationBanner.tsx; the modal content remains in CampaignHero, the standalone page placement stays removed, and CI is green.
Findings
- [ok] Follow-up deletion removes an unused component after its content moved into the hero modal.
- File:
src/components/airdrop/InnovationBanner.tsx
- File:
- [ok] Hero modal trigger and modal content remain intact.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Branch is mergeable and checks passed after the follow-up commit:
lint-and-typecheck,e2e, Vercel.- File: PR checks
Decision
Approve. PR #1033 still matches #1029 acceptance criteria and is ready to merge.
Summary
<InnovationBanner />from the airdrop page layoutCloses #1029
Test plan
🤖 Generated with Claude Code