Skip to content

Move innovation comparison to modal from hero (#1029)#1033

Merged
realproject7 merged 2 commits intomainfrom
feat/innovation-modal-1029
May 4, 2026
Merged

Move innovation comparison to modal from hero (#1029)#1033
realproject7 merged 2 commits intomainfrom
feat/innovation-modal-1029

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Adds "Why is this airdrop different? →" link in the hero section (between headline and countdown)
  • Click opens a modal with the two-column comparison (Typical Airdrop vs This Airdrop) and summary paragraph
  • Removes inline <InnovationBanner /> from the airdrop page layout
  • Modal closes on backdrop click or X button, stops propagation on content click

Closes #1029

Test plan

  • "Why is this airdrop different?" link visible in hero
  • Clicking opens modal with comparison content
  • Modal closes on X button click
  • Modal closes on backdrop click
  • Content click doesn't close modal
  • Mobile-friendly modal layout
  • InnovationBanner no longer shows as standalone section on page
  • No layout breakage

🤖 Generated with Claude Code

Add "Why is this airdrop different?" link in the hero that opens a
modal with the two-column comparison (Typical vs This Airdrop) and
summary text. Remove the inline InnovationBanner from the page layout.
Modal closes on backdrop click or X button.

Bump version: 1.3.3 → 1.4.0

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored May 4, 2026 3:19am

Request Review

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR implements issue #1029 cleanly: the hero now has a "Why is this airdrop different?" trigger, clicking it opens a modal with the existing comparison content, and the standalone InnovationBanner placement is removed from the airdrop page.

Findings

  • [ok] Hero includes the requested modal trigger link.
    • File: src/components/airdrop/CampaignHero.tsx
  • [ok] Modal contains the prior two-column comparison and summary content, and supports close button plus backdrop click dismissal.
    • File: src/components/airdrop/CampaignHero.tsx
  • [ok] Inline standalone InnovationBanner section was removed from the page layout.
    • File: src/app/airdrop/page.tsx
  • [ok] Branch is mergeable and checks passed: lint-and-typecheck, e2e, Vercel.
    • File: PR checks

Decision

Approve. The change is focused, matches #1029 acceptance criteria, and passes CI.

Copy link
Copy Markdown
Owner Author

@realproject7 realproject7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RE2 Verdict: APPROVE (with minor nit)

Summary

Clean implementation of #1029. Modal trigger in hero, comparison content in modal, InnovationBanner removed from page layout. Modal has backdrop close, X button, and stopPropagation on content. Version bump 1.3.3 → 1.4.0 appropriate for feature work.

Findings

  • [ok] "Why is this airdrop different? →" link placed between headline and countdown — matches wireframe.
  • [ok] Modal content matches spec: two-column comparison (Typical vs This), summary paragraph.
  • [ok] Modal closes on backdrop click and X button; content click doesn't close (stopPropagation).
  • [ok] InnovationBanner import and usage removed from airdrop/page.tsx.
  • [ok] Responsive: grid-cols-1 sm:grid-cols-2 for modal columns.
  • [ok] Version bump 1.3.3 → 1.4.0 correct for feature.
  • [ok] Mergeable.
  • [nit] InnovationBanner.tsx is now orphaned (no imports anywhere). Could be deleted in this PR or a follow-up — not blocking.

Decision

Approve. LGTM.

Content now lives in the CampaignHero modal; no remaining imports.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@realproject7 realproject7 merged commit e118aa3 into main May 4, 2026
4 checks passed
Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

Re-reviewed after the follow-up commit. The added commit only deletes the now-orphaned InnovationBanner.tsx; the modal content remains in CampaignHero, the standalone page placement stays removed, and CI is green.

Findings

  • [ok] Follow-up deletion removes an unused component after its content moved into the hero modal.
    • File: src/components/airdrop/InnovationBanner.tsx
  • [ok] Hero modal trigger and modal content remain intact.
    • File: src/components/airdrop/CampaignHero.tsx
  • [ok] Branch is mergeable and checks passed after the follow-up commit: lint-and-typecheck, e2e, Vercel.
    • File: PR checks

Decision

Approve. PR #1033 still matches #1029 acceptance criteria and is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airdrop: move 'How is this different?' to modal triggered from hero

2 participants