Replace milestone cards with MCap progress chart (#1035)#1038
Merged
realproject7 merged 1 commit intomainfrom May 4, 2026
Merged
Replace milestone cards with MCap progress chart (#1035)#1038realproject7 merged 1 commit intomainfrom
realproject7 merged 1 commit intomainfrom
Conversation
Replace the 4 static milestone cards with an SVG area chart showing current MCap progress toward $100M. Features: accent gradient fill, heartbeat animated dot at current position, vertical dashed milestone markers, desktop labels inline above chart, mobile letter markers (A/B/C/D) with legend grid below. Linear scale, responsive width. Bump version: 1.5.0 → 1.6.0 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
commented
May 4, 2026
Owner
Author
realproject7
left a comment
There was a problem hiding this comment.
RE2 Verdict: APPROVE
Summary
Well-implemented replacement of milestone cards with an SVG MCap progress chart. All acceptance criteria met.
Findings
- [ok] SVG area chart with linear scale $0 → $100M,
preserveAspectRatio="none", responsive viaw-full. - [ok] Accent gradient fill (
#00ff88at 40% → 5% opacity) up to current MCap. - [ok] Heartbeat dot with Tailwind
animate-pingat current position. - [ok] 4 vertical dashed milestone markers at correct positions ($1M/$10M/$50M/$100M).
- [ok] Desktop: inline labels above chart with MCap, unlock %, CMC rank — hidden on mobile via
hidden sm:block. - [ok] Mobile: letter markers (A/B/C/D) on chart via
sm:hiddenSVG text + 2-col legend grid below. - [ok] Font sizes:
text-sm(14px) for MCap/unlock%,text-xs(12px) for CMC rank — meets minimum. - [ok] Good accessibility:
role="img"andaria-labelon SVG. - [ok] Version bump 1.5.0 → 1.6.0 correct for feature.
- [ok] CI green, mergeable.
- [nit] Heartbeat dot overlay uses
-mt-[52px]magic number — fragile but works since SVG viewBox is fixed. Not blocking.
Decision
Approve. LGTM.
project7-interns
approved these changes
May 4, 2026
Collaborator
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR implements issue #1035 cleanly: milestone cards are replaced with a responsive SVG MCap progress chart using a linear $0 → $100M scale, gradient fill, current-position heartbeat dot, milestone markers, desktop labels, and mobile legend.
Findings
- [ok] SVG chart uses a linear $0 → $100M scale with filled accent-gradient progress up to current MCap.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Current MCap heartbeat dot and milestone dashed markers are present at the expected positions.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Desktop labels and mobile A/B/C/D legend cover MCap, unlock %, and CMC rank with readable font sizes.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
- [ok] Branch is mergeable and checks passed:
lint-and-typecheck,e2e, Vercel.- File: PR checks
- [nit] The heartbeat dot overlay uses a fixed negative margin, which is somewhat fragile but acceptable with the fixed SVG height.
- File:
src/components/airdrop/CampaignHero.tsx
- File:
Decision
Approve. The change is focused, matches #1035 acceptance criteria, and passes CI.
This was referenced May 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
animate-ping) at current MCapCloses #1035
Test plan
🤖 Generated with Claude Code