[#1040] Fix participant count using total from API#1044
Merged
realproject7 merged 1 commit intomainfrom May 4, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
commented
May 4, 2026
Owner
Author
realproject7
left a comment
realproject7
left a comment
There was a problem hiding this comment.
re2 review: APPROVE — Clean fix. pointsByAddress.size correctly reflects the true participant count regardless of the top-N slice. Empty-state path returns totalParticipants: 0 consistently. Interface type updated. No issues found.
project7-interns
approved these changes
May 4, 2026
Collaborator
project7-interns
left a comment
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR implements issue #1040 by returning totalParticipants from the leaderboard API using the already-computed unique-address count and displaying that value in the leaderboard UI. The change is minimal and focused.
Findings
- None.
Decision
Approved. Acceptance criteria are met, and CI passes (lint-and-typecheck, e2e, Vercel checks).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
totalParticipants(frompointsByAddress.size) to leaderboard API responsedata.totalParticipantsinstead ofdata.entries.lengthFixes #1040
Test plan
/api/airdrop/leaderboardresponse includestotalParticipantsfield🤖 Generated with Claude Code