[#1041] Add pagination to leaderboard#1045
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
There was a problem hiding this comment.
re2 review: APPROVE — Clean pagination implementation. API correctly clamps page/limit params, paginates the sorted array with proper rank offsets, and scopes the username lookup to current-page addresses only. Component uses per-page React Query keys, properly disables Prev/Next at boundaries, and distinguishes empty-page from zero-participants. No issues found.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR adds leaderboard pagination as requested: the API accepts page/limit, returns pagination metadata, and the component uses per-page React Query caching with Prev/Next controls and rank display outside the current page. The change is focused on issue #1041.
Findings
- None.
Decision
Approved. Acceptance criteria are met, and CI passes (lint-and-typecheck, e2e, Vercel checks).
Summary
page(default 1) andlimit(default 20, max 50) query paramstotalParticipants,page,totalPages,limitin responseFixes #1041
Test plan
/api/airdrop/leaderboard?page=1&limit=20returns correct pagination metadata🤖 Generated with Claude Code