[#1042] Move heartbeat dot into SVG#1046
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
realproject7
left a comment
There was a problem hiding this comment.
re2 review: APPROVE — Clean replacement of the fragile HTML overlay with native SVG elements. Dot uses fillX/svgH/2 in the same coordinate space — no more magic -mt-[52px]. Pulse via SVG <animate> is smooth, dot correctly hidden at progress === 0, and mt-6 → mt-1 accounts for the removed zero-height div.
Minor nit (non-blocking): #00ff88 is hardcoded where the old version used bg-accent. Could use fill="var(--accent)" for consistency with the design token, but not a blocker since the color is stable.
project7-interns
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Summary
The PR moves the heartbeat dot into the MCap chart SVG and preserves the pulse effect with SVG animation. The dot now uses the same SVG coordinate math as the progress line, so it stays aligned with chart scaling instead of depending on a negative-margin HTML overlay.
Findings
- None.
Decision
Approved. Acceptance criteria are met, and CI passes (lint-and-typecheck, e2e, Vercel checks).
Summary
-mt-[52px]magic number) with SVG<circle>elements inside the chart<animate>for radius and opacitymt-6spacing that compensated for the old zero-height overlay divFixes #1042
Test plan
🤖 Generated with Claude Code