Skip to content

[#1042] Move heartbeat dot into SVG#1046

Merged
realproject7 merged 1 commit intomainfrom
task/1042-mcap-chart-svg-dot
May 4, 2026
Merged

[#1042] Move heartbeat dot into SVG#1046
realproject7 merged 1 commit intomainfrom
task/1042-mcap-chart-svg-dot

Conversation

@realproject7
Copy link
Copy Markdown
Owner

Summary

  • Replace fragile HTML overlay (-mt-[52px] magic number) with SVG <circle> elements inside the chart
  • Pulse animation using SVG <animate> for radius and opacity
  • Dot stays pixel-perfect at all viewport sizes since it shares the SVG coordinate space
  • Removed extra mt-6 spacing that compensated for the old zero-height overlay div

Fixes #1042

Test plan

  • Verify heartbeat dot renders at the correct position on the MCap progress line
  • Verify pulse animation works (expanding ring effect)
  • Verify alignment holds on mobile and desktop viewports
  • Verify dot hidden when progress is 0

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented May 4, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
plotlink Ignored Ignored May 4, 2026 1:34pm

Request Review

Copy link
Copy Markdown
Owner Author

@realproject7 realproject7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

re2 review: APPROVE — Clean replacement of the fragile HTML overlay with native SVG elements. Dot uses fillX/svgH/2 in the same coordinate space — no more magic -mt-[52px]. Pulse via SVG <animate> is smooth, dot correctly hidden at progress === 0, and mt-6mt-1 accounts for the removed zero-height div.

Minor nit (non-blocking): #00ff88 is hardcoded where the old version used bg-accent. Could use fill="var(--accent)" for consistency with the design token, but not a blocker since the color is stable.

Copy link
Copy Markdown
Collaborator

@project7-interns project7-interns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: APPROVE

Summary

The PR moves the heartbeat dot into the MCap chart SVG and preserves the pulse effect with SVG animation. The dot now uses the same SVG coordinate math as the progress line, so it stays aligned with chart scaling instead of depending on a negative-margin HTML overlay.

Findings

  • None.

Decision

Approved. Acceptance criteria are met, and CI passes (lint-and-typecheck, e2e, Vercel checks).

@realproject7 realproject7 merged commit f41b6a7 into main May 4, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Airdrop: heartbeat dot positioning is fragile in MCap chart

2 participants