add support for uefi bootet systems in usb-install #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@equinox0815 It's a bit big for a no-sleep review, but if you fix the merge conflict, I can review later in the week.\ |
equinox0815
force-pushed
the
usb-install/uefi
branch
from
d6fb457 to
5b85b2d
Compare
Member
Author
|
Merge conflict is fixed. We don't really need this change at the moment. I had do add it in my private repo the other day and i just wanted to merge it in here as well. So take your time! |
nicoonoclaste
previously approved these changes
Feb 25, 2019
| d-i partman-lvm/confirm_nooverwrite boolean true | ||
|
|
||
| {% if (hostvars[hostname].install_cooked.efi | default(false)) %} | ||
| d-i partman-efi/non_efi_system boolean true |
Member
There was a problem hiding this comment.
I approved a bit fast. partman-efi/non_efi_system is set to true when installing on an EFI system? O_o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.