Skip to content

Conversation

@tatchi
Copy link
Contributor

@tatchi tatchi commented Apr 11, 2023

No description provided.

@anmonteiro
Copy link
Member

We could probably just replaced it? React 18 is on the roadmap but 17 could go in in the meantime.

@tatchi tatchi force-pushed the add-react-17-devdeps branch from f15fe07 to c248296 Compare April 12, 2023 13:36
@tatchi
Copy link
Contributor Author

tatchi commented Apr 12, 2023

We could probably just replaced it? React 18 is on the roadmap but 17 could go in in the meantime.

But keeping only react 17 would mean that reason-react is not compatible with older versions, right? Maybe you got confused by my previous commit message that mentioned devDependencies instead of peerDependencies 🙈

@davesnx
Copy link
Member

davesnx commented Aug 24, 2023

Closing in favor of #761

@davesnx davesnx closed this Aug 24, 2023
@jchavarri
Copy link
Collaborator

To add a bit more context, now that we have opam-check-npm-deps plugin, we can move the "peer dependencies" to the depexts field in the opam file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants