Skip to content

feat: no_std#274

Merged
prestwich merged 3 commits intorecmo:mainfrom
DaniPopes:no_std2
Jul 27, 2023
Merged

feat: no_std#274
prestwich merged 3 commits intorecmo:mainfrom
DaniPopes:no_std2

Conversation

@DaniPopes
Copy link
Contributor

Motivation

Make ruint no_std-compatible.

Supersedes #260.

Solution

See original description in #260.
Since core::error::Error is unstable, we instead implement the formatting using core::fmt and gate impl std::error::Error with #[cfg(feature = "std")]

PR Checklist

  • Added Tests
  • Added Documentation
  • Updated the changelog

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 13.20% and project coverage change: -0.59% ⚠️

Comparison is base (4b04138) 83.37% compared to head (5538096) 82.79%.

❗ Current head 5538096 differs from pull request most recent head 558af3e. Consider uploading reports for the commit 558af3e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #274      +/-   ##
==========================================
- Coverage   83.37%   82.79%   -0.59%     
==========================================
  Files          52       52              
  Lines        5541     5585      +44     
==========================================
+ Hits         4620     4624       +4     
- Misses        921      961      +40     
Files Changed Coverage Δ
ruint-macro/src/lib.rs 96.42% <ø> (ø)
src/algorithms/div/knuth.rs 100.00% <ø> (ø)
src/algorithms/div/reciprocal.rs 100.00% <ø> (ø)
src/algorithms/gcd/matrix.rs 93.54% <ø> (ø)
src/bit_arr.rs 21.35% <ø> (ø)
src/bytes.rs 96.71% <ø> (ø)
src/lib.rs 81.05% <ø> (ø)
src/log.rs 84.16% <ø> (ø)
src/pow.rs 93.20% <ø> (ø)
src/root.rs 100.00% <ø> (ø)
... and 9 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gakonst gakonst mentioned this pull request Jul 27, 2023
@DaniPopes
Copy link
Contributor Author

DaniPopes commented Jul 27, 2023

Coverage is actually unchanged because it didn't count code generated by the thiserror macro

Copy link
Collaborator

@prestwich prestwich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants