perf: special case small integers in fmt#500
Merged
prestwich merged 1 commit intorecmo:mainfrom Jul 22, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #500 will improve performances by ×2.3Comparing Summary
Benchmarks breakdown
|
ecebd71 to
5f30fa8
Compare
5f30fa8 to
102e883
Compare
prestwich
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very cheap check to avoid using
to_base_beat all when the integer is small enough. It doesn't show any improvements in the benchmarks for >128 bits because the numbers are uniformly sampled, so they will always be at full bits, but it's a massive speed up as can be seen from the 64 and 128 bit benchmarks.Based on #490.