Skip to content

Refactoring/subreddit input#21

Merged
Mxiim merged 4 commits intodevfrom
refactoring/subreddit-input
Apr 10, 2017
Merged

Refactoring/subreddit input#21
Mxiim merged 4 commits intodevfrom
refactoring/subreddit-input

Conversation

@Jaxing
Copy link
Copy Markdown
Contributor

@Jaxing Jaxing commented Apr 6, 2017

The model takes subreddits as one hot vector instead of an index. Also handels exceptions in main and removed bias from l2.

@hsson hsson requested a review from Mxiim April 6, 2017 15:55
@hsson
Copy link
Copy Markdown
Contributor

hsson commented Apr 6, 2017

The logging of error should maybe be written to a file and not just printed to the console. Any ideas on how to do this? @Mxiim ?

@hsson
Copy link
Copy Markdown
Contributor

hsson commented Apr 6, 2017

Also, this should solve issues #19 and #20

@Mxiim
Copy link
Copy Markdown
Member

Mxiim commented Apr 6, 2017

Code looks good to me.
@hsson We can create a model-specific log-file in the directory for that model, similar to the old README.txt but with logs of errors. However, the errors can be seen in tensorboard and I think we can remove the prints completely and use tensorboard. (There is also an option of downloading from tensorboard).

@Mxiim Mxiim merged commit 73b5a23 into dev Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants