Merged
Conversation
dbellettini
force-pushed
the
php-8.4
branch
2 times, most recently
from
eda4d33 to
14b4f56
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the PHP version requirement from PHP 7.1 to PHP 8.4, modernizing the codebase to take advantage of newer PHP features and updating dependencies to compatible versions.
- Updates PHP version requirement from ^7.1 to ^8.4 in composer.json
- Modernizes code with PHP 8+ features like typed properties, constructor promotion, and attributes
- Updates PHPUnit from v8 to v12 and PHPStan from v0.11 to v2.1 with corresponding API changes
Reviewed Changes
Copilot reviewed 29 out of 29 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| composer.json | Updates PHP requirement to ^8.4 and bumps PHPUnit/PHPStan versions |
| Dockerfile | Changes base image from php:7.4-cli to php:8.4-cli |
| phpunit.xml | Updates PHPUnit configuration schema to v12.3 |
| phpstan.neon | Updates PHPStan configuration syntax for newer version |
| tests/PreciousTest.php | Replaces @dataProvider with #[DataProvider] attribute |
| src/Type/*.php | Adds typed parameters and return types to cast methods |
| src/PHPStan/Rule/*.php | Updates PHPStan API usage from Broker to ReflectionProvider |
| src/*.php | Modernizes with constructor promotion and readonly properties |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.