Update to PHP 8.4 and new dependencies#3
Merged
dbellettini merged 59 commits intomasterfrom Aug 4, 2025
Merged
Conversation
bdefab7 to
bec54fa
Compare
But tests are still flaky
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the codebase to PHP 8.4 compatibility with comprehensive updates to modern PHP language features and coding standards. The upgrade includes dependency updates, automated code modernization via Rector, and coding standards fixes.
- Update type declarations and return types for PHP 8.4 compatibility
- Modernize class properties with constructor promotion and readonly modifiers
- Replace legacy syntax with modern PHP 8+ alternatives
- Fix coding standards and improve type safety throughout
Reviewed Changes
Copilot reviewed 131 out of 133 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/Timeless/*.php | Add type declarations, use constructor promotion, modernize DateTime usage |
| src/Sink/BlackHole.php | Add Stringable interface, improve type declarations |
| src/Recruiter/*.php | Extensive type safety improvements, constructor promotion, modern syntax |
| spec/**/*.php | Update test methods with void return types, modernize assertions |
Comments suppressed due to low confidence (1)
src/Recruiter/Workable/ExitsAbruptly.php:8
- The class name was changed from
ThrowsFatalErrortoExitsAbruptly, but the behavior implementation callsexit(-1)instead of throwing a fatal error. The new name better reflects the actual behavior, but this change should be verified for consistency with expected behavior in tests and usage.
class ExitsAbruptly implements Workable
dbellettini
added a commit
that referenced
this pull request
Aug 15, 2025
Update to PHP 8.4 and new dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.