Skip to content

Update to PHP 8.4 and new dependencies#3

Merged
dbellettini merged 59 commits intomasterfrom
php-8.4
Aug 4, 2025
Merged

Update to PHP 8.4 and new dependencies#3
dbellettini merged 59 commits intomasterfrom
php-8.4

Conversation

@dbellettini
Copy link
Member

@dbellettini dbellettini commented Aug 2, 2025

  • Upgrade PHP 8.4
  • Upgrade Dependencies
  • Upgrade code with rector
  • Fix Coding Standards

@dbellettini dbellettini force-pushed the php-8.4 branch 4 times, most recently from bdefab7 to bec54fa Compare August 2, 2025 22:54
@dbellettini dbellettini marked this pull request as ready for review August 4, 2025 22:41
@dbellettini dbellettini requested a review from Copilot August 4, 2025 22:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades the codebase to PHP 8.4 compatibility with comprehensive updates to modern PHP language features and coding standards. The upgrade includes dependency updates, automated code modernization via Rector, and coding standards fixes.

  • Update type declarations and return types for PHP 8.4 compatibility
  • Modernize class properties with constructor promotion and readonly modifiers
  • Replace legacy syntax with modern PHP 8+ alternatives
  • Fix coding standards and improve type safety throughout

Reviewed Changes

Copilot reviewed 131 out of 133 changed files in this pull request and generated 3 comments.

File Description
src/Timeless/*.php Add type declarations, use constructor promotion, modernize DateTime usage
src/Sink/BlackHole.php Add Stringable interface, improve type declarations
src/Recruiter/*.php Extensive type safety improvements, constructor promotion, modern syntax
spec/**/*.php Update test methods with void return types, modernize assertions
Comments suppressed due to low confidence (1)

src/Recruiter/Workable/ExitsAbruptly.php:8

  • The class name was changed from ThrowsFatalError to ExitsAbruptly, but the behavior implementation calls exit(-1) instead of throwing a fatal error. The new name better reflects the actual behavior, but this change should be verified for consistency with expected behavior in tests and usage.
class ExitsAbruptly implements Workable

@dbellettini dbellettini merged commit f5f323f into master Aug 4, 2025
3 checks passed
@dbellettini dbellettini deleted the php-8.4 branch August 4, 2025 22:46
dbellettini added a commit that referenced this pull request Aug 15, 2025
Update to PHP 8.4 and new dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments