Remove OverlapError, as it is no longer required#144
Merged
Conversation
EdwardLarson
approved these changes
Dec 15, 2022
whyitfor
added a commit
that referenced
this pull request
Dec 16, 2022
- Remove MemoryOverlapError (and its error handling). Like OverlapError(#144), this error is never raised - Add unit tests for MemoryRegion.{__str__, __hash__}
EdwardLarson
pushed a commit
that referenced
this pull request
Dec 19, 2022
- Remove MemoryOverlapError (and its error handling). Like OverlapError(#144), this error is never raised - Add unit tests for MemoryRegion.{__str__, __hash__}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please describe the changes in your request.
Remove
OverlapError. Since #40, this is no longer an error raised by the data service.Anyone you think should look at this, specifically?
@EdwardLarson