Skip to content

Add JFFS2 Packer/Unpacker#326

Merged
rbs-jacob merged 13 commits into
redballoonsecurity:masterfrom
marczalik:feature/jffs2-packer-unpacker
Jun 19, 2023
Merged

Add JFFS2 Packer/Unpacker#326
rbs-jacob merged 13 commits into
redballoonsecurity:masterfrom
marczalik:feature/jffs2-packer-unpacker

Conversation

@marczalik
Copy link
Copy Markdown
Contributor

@marczalik marczalik commented Jun 7, 2023

One sentence summary of this PR (This should go in the CHANGELOG!)
This draft PR adds a JFFS2 packer/unpacker using the Jefferson Python package and mkfs.jffs2 from mtd-utils.

Link to Related Issue(s)

Please describe the changes in your request.
Add support to pack and unpack JFFS2 filesystems.

Note: I haven't been able to find a readily available mtd-utils package for Apple Silicon, so for M1 support it may need to be cross-compiled. Directions here (I haven't tested this yet).

Anyone you think should look at this, specifically?
@rbs-jacob

@marczalik marczalik changed the title Add JFFS2 unpacker Add JFFS2 Packer/Unpacker Jun 9, 2023
@marczalik marczalik marked this pull request as ready for review June 12, 2023 19:44
Copy link
Copy Markdown
Contributor

@EdwardLarson EdwardLarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good! Can you merge master into this branch though first please? Since we just did a release and shifted the changelog around, the automatic merge (though there are no conflicts) is prone to incorrectly placing new changelog entries into sections for existing releases.

@marczalik
Copy link
Copy Markdown
Contributor Author

Changes look good! Can you merge master into this branch though first please? Since we just did a release and shifted the changelog around, the automatic merge (though there are no conflicts) is prone to incorrectly placing new changelog entries into sections for existing releases.

Sure can!

@marczalik marczalik requested a review from EdwardLarson June 13, 2023 15:59
Copy link
Copy Markdown
Member

@rbs-jacob rbs-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change requested. One additional, general question that shouldn't block merging this.

Comment thread ofrak_core/Dockerstub
Comment thread ofrak_core/ofrak/core/jffs2.py Outdated
@marczalik marczalik requested a review from rbs-jacob June 13, 2023 21:12
Copy link
Copy Markdown
Member

@rbs-jacob rbs-jacob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up on all of the threads – looks good to me!

@rbs-jacob rbs-jacob merged commit 5b3302e into redballoonsecurity:master Jun 19, 2023
@EdwardLarson EdwardLarson mentioned this pull request Aug 10, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants