Merged gui searches#345
Merged
Merged
Conversation
… probably doesnt belong there
This was referenced Jul 6, 2023
Closed
rbs-jacob
requested changes
Jul 7, 2023
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Some changes requested. Also, as I type, I repeatedly get some errors in the console that should probably be handled silently.
rbs-jacob
requested changes
Jul 10, 2023
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Two very minor fixes, and this is good to go! We're almost there!
rbs-jacob
requested changes
Jul 11, 2023
rbs-jacob
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add a search bar to the ResourceTreeView to filter resources by string and bytes.
Add searchbar to HexView in order to search for a string or bytes within a resource.
Link to Related Issue(s)
Combines #336 and #334
Please describe the changes in your request.
Adds a Svelte implementation a search bar with two usages in the GUI: One to search the resource tree for all resources containing some bytes/string, and one to search the currently selected resource for bytes/string.
For more details, see the individual PRs.
Anyone you think should look at this, specifically?
@dannyp303
@rbs-jacob