Intel Hex format unpacker/packer#349
Merged
rbs-jacob merged 9 commits intoAug 3, 2023
Merged
Conversation
rbs-jacob
requested changes
Aug 3, 2023
Member
There was a problem hiding this comment.
It probably makes sense to change the packer and unpacker to become two packers and two unpackers.
Right now both have two distinct code paths that case on tags. This is exactly what separate components are for, and I don't see the benefit to having those if statements each be inside one packer/unpacker instead of having the cases broken up across different packers and unpackers.
rbs-jacob
changed the title
rbs-jacob
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add Identifier, Unpacker, Packer for Intel Hex format
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?