Add styling for disabled buttons#354
Merged
rbs-jacob merged 4 commits intoAug 3, 2023
Merged
Conversation
EdwardLarson
changed the title
rbs-jacob
requested changes
Aug 3, 2023
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
It looks good!
One small suggestion is to change the cursor for disabled buttons. Otherwise, this is good to go.
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
rbs-jacob
approved these changes
Aug 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add styling for buttons in the GUI when they are disabled.
Link to Related Issue(s)
Please describe the changes in your request.
In order to do this, I at first added new global style vars calculated by blending the background and foreground colors, and were part of the settings structure. All that ended up being unnecessary, but it did lead to a small improvement to the settings loading that handles future, new settings which might not be in the user's cached settings.
Anyone you think should look at this, specifically?
@rbs-jacob