Save resources affected by data patches and dependency updates on a re…#355
Merged
rbs-jacob merged 1 commit intoAug 7, 2023
Conversation
…source being saved
rbs-jacob
approved these changes
Aug 3, 2023
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
The changes here make sense to me individually, but I don't totally understand how they come together to solve the original bug. Still, as far as I can tell, this seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…source being saved
One sentence summary of this PR (This should go in the CHANGELOG!)
Save resources affected by data patches and dependency updates on a resource being saved
Link to Related Issue(s)
Calling
resource.save()will apply data patches, which for mapped resources will also modify one or more ancestors. Without these changes, those resources would be marked as "dirty" after the originalsavecall. This has the confusing result of making local state overall "dirtier" after asavecall, rather than less.Please describe the changes in your request.
With these changes, if
savecall on one resource modifies other resources, those resources' models will also be pushed and not dirty.Anyone you think should look at this, specifically?
@dannyp303