Use python3.8 in docker images#416
Conversation
This is needed becase of pytest-dev/pytest#11890 TvoroG/pytest-lazy-fixture#65
This reverts commit 500ee9b. Making changes before having coffee :(
whyitfor
left a comment
whyitfor
left a comment
There was a problem hiding this comment.
With this change, all of our testing will be done on Python 3.8.
Since python3.7 is eol, we will eventually want to update the python_requires for the ofrak setup.py files to alert dropping of 3.7. This isn't strictly needed now, though, and could arguably cause annoyance to users of OFRAK currently on 3.7.
@ANogin, perhaps it makese sense to add to the README or to the documentation a note that 3.7 is generally supported by that all testing is done on 3.8, which is the recommended version?
There were two places in the documentation that specified the Python version, I've added a note to both. |
|
@EdwardLarson, do you think this necessitates changelog entires? My read is no: the changelogs seem to describe the Python projects, and not necessarily the Docker build environment. |
Nah, I agree with your take on the changelog. This is not a new feature/bugfix. |
* Use python3.8 in docker images * Require pytest<8.0 This is needed becase of pytest-dev/pytest#11890 TvoroG/pytest-lazy-fixture#65 * Update changelog * Revert "Update changelog" This reverts commit 500ee9b. Making changes before having coffee :( * Add a note on recommending Python 3.8 * `ofrak_core` also needs `pytest<8.0`
3 participants
One sentence summary of this PR (This should go in the CHANGELOG!)
Update docker configuration to use Python 3.8, rather than 3.7
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Switches the docker configuration from the previous pinned python:3.7-bullseye docker version to the latest-as-of-today python:3.8-bullseye one.
Anyone you think should look at this, specifically?
@whyitfor