Move away from $OFRAK_DIR argument to $PACKAGE_PATH for Docker builds#425
Merged
Conversation
whyitfor
changed the title
ANogin
reviewed
Feb 18, 2024
rbs-jacob
approved these changes
Feb 22, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Haven't run it myself to test, but after a quick pass, this seems like a positive improvement that makes sense.
- $PACKAGE_PATH generalizes build_image.py such that it works with any yaml file containing a valid list of Python packages Before this change, it was possible to use build_image.py a directory above the OFRAK repository by passing in an OFRAK_DIR arugment in the yml file. This change generalizes the approach so that build_image.py can be run in any ancestor directory.
whyitfor
force-pushed
the
maintenance/package_dir
branch
from
24d06cb to
de92275
Compare
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
…ds (redballoonsecurity#425) - $PACKAGE_PATH generalizes build_image.py such that it works with any yaml file containing a valid list of Python packages Before this change, it was possible to use build_image.py a directory above the OFRAK repository by passing in an OFRAK_DIR arugment in the yml file. This change generalizes the approach so that build_image.py can be run in any ancestor directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Before this change, it was possible to use build_image.py a directory above the OFRAK repository by passing in an OFRAK_DIR arugment in the yml file. This change generalizes the approach so that build_image.py can be run in any ancestor directory; it also removes the need to pass in an OFRAK_DIR argument.
Link to Related Issue(s)
N/A.
Please describe the changes in your request.
See above.
Anyone you think should look at this, specifically?
@rbs-jacob