Feature/angr decompilation view#436
Merged
rbs-jacob merged 24 commits intoMar 4, 2024
Merged
Conversation
rbs-jacob
requested changes
Mar 1, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Some suggested changes.
One thing I'm confused about is: where is the code to make angr pull the decompilation output into OFRAK? I don't see that in this PR. Is that already a part of OFRAK somewhere?
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
rbs-jacob
requested changes
Mar 1, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Last small changes. But it looks pretty much good to go to me!
rbs-jacob
requested changes
Mar 1, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
One last thing then good to go
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
…3/ofrak into feature/angr_decompilation_view
rbs-jacob
requested changes
Mar 4, 2024
rbs-jacob
approved these changes
Mar 4, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
--------- Co-authored-by: Dan Pesce <dan@redballoonsecurity.com> Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add a content view and decompilation view to the OFRAK gui.
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?