add lief add/remove section modifier#443
Merged
dannyp303 merged 3 commits intoMar 12, 2024
Merged
Conversation
added 2 commits
March 12, 2024 14:29
Member
|
Since LIEF can handle PE files, I wonder if it makes sense to also allow these modifiers to target OFRAK |
whyitfor
reviewed
Mar 12, 2024
| assert not segment_exists(modified, ".text") | ||
|
|
||
|
|
||
| def segment_exists(filepath: str, name: str, content: Optional[bytes] = None): |
Contributor
There was a problem hiding this comment.
Shouldn't this be section_exists?
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
* add lief add/remove section modifier * Changelog * typo --------- Co-authored-by: Dan Pesce <dan@redballoonsecurity.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add modifier to add and remove sections using lief.
Link to Related Issue(s)
Please describe the changes in your request.
Anyone you think should look at this, specifically?