Skip to content

Support make -k test in docker root#446

Merged
whyitfor merged 2 commits into
redballoonsecurity:masterfrom
ANogin:feature/make_k_in_docker
Mar 21, 2024
Merged

Support make -k test in docker root#446
whyitfor merged 2 commits into
redballoonsecurity:masterfrom
ANogin:feature/make_k_in_docker

Conversation

@ANogin
Copy link
Copy Markdown
Contributor

@ANogin ANogin commented Mar 20, 2024

One sentence summary of this PR (This should go in the CHANGELOG!)
Creates an individual target in the root Makefile for each package's make test, with test depending on all of them

Link to Related Issue(s)
N/A

Please describe the changes in your request.
Creates an individual target in the root Makefile for each package's make test, with test depending on all of them. This has a number of advantages, the biggest (and my motivation) is that this way make -k test in the container root would run through all the packages, rather than stopping on the first one with errors.

Here is an example of the relevant section of Makefile created for ofrak-core-dev.yml with this change:

.PHONY: test test_ofrak_type test_ofrak_io test_ofrak_patch_maker test_ofrak_core test_frontend
test: test_ofrak_type test_ofrak_io test_ofrak_patch_maker test_ofrak_core test_frontend
test_ofrak_type:
        $(MAKE) -C ofrak_type test
test_ofrak_io:
        $(MAKE) -C ofrak_io test
test_ofrak_patch_maker:
        $(MAKE) -C ofrak_patch_maker test
test_ofrak_core:
        $(MAKE) -C ofrak_core test
test_frontend:
        $(MAKE) -C frontend test

Anyone you think should look at this, specifically?
Not sure - maybe @whyitfor?

@whyitfor whyitfor self-requested a review March 20, 2024 18:55
@whyitfor
Copy link
Copy Markdown
Contributor

@ANogin, looks like you need to run the pre-commit hook against this changeset.

@ANogin
Copy link
Copy Markdown
Contributor Author

ANogin commented Mar 20, 2024

@ANogin, looks like you need to run the pre-commit hook against this changeset.

Done, not sure why they did not run in the first place, weird...

Copy link
Copy Markdown
Contributor

@whyitfor whyitfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@whyitfor whyitfor merged commit 5b1f791 into redballoonsecurity:master Mar 21, 2024
ANogin pushed a commit to ANogin/ofrak that referenced this pull request May 30, 2024
* Support `make -k test` in docker root

* Lint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants