Support make -k test in docker root#446
Merged
whyitfor merged 2 commits intoMar 21, 2024
Merged
Conversation
Contributor
|
@ANogin, looks like you need to run the pre-commit hook against this changeset. |
Contributor
Author
Done, not sure why they did not run in the first place, weird... |
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
May 30, 2024
* Support `make -k test` in docker root * Lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Creates an individual target in the root
Makefilefor each package'smake test, withtestdepending on all of themLink to Related Issue(s)
N/A
Please describe the changes in your request.
Creates an individual target in the root
Makefilefor each package'smake test, withtestdepending on all of them. This has a number of advantages, the biggest (and my motivation) is that this waymake -k testin the container root would run through all the packages, rather than stopping on the first one with errors.Here is an example of the relevant section of
Makefilecreated forofrak-core-dev.ymlwith this change:Anyone you think should look at this, specifically?
Not sure - maybe @whyitfor?