Explicitly set the Binary Ninja package file name#451
Merged
rbs-jacob merged 1 commit intoApr 4, 2024
Merged
Conversation
rbs-jacob
approved these changes
Apr 4, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Pending passing tests, looks good to me!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Explicitly set the Binary Ninja downloaded package file name, so that the installer script knows what to unzip.
Link to Related Issue(s)
#450
Please describe the changes in your request.
The Binary Ninja accepts an
--outputargument which sets the name of the downloaded Binary Ninja package. This PR uses that argument to set the output file name tobinaryninja-headless.zip, so that the script knows what the downloaded .zip is named. This should work across platforms and prevent renaming issues from occurring in the future.Anyone you think should look at this, specifically?
@whyitfor