Use aiofiles for filesystem IO#466
Closed
ANogin wants to merge 4 commits into
Closed
Conversation
Contributor
Author
|
No longer sure this would make things faster rather than slower, marking as draft for now. I did a timing test of a gather of 2x ( where I used the approach from https://gist.github.com/vxgmichel/620eb3a02d97d3da9dacdc508a5d5321 to break the non-CPU time into “select” vs “blocked IO”. |
Contributor
Author
|
With #472 merged into master and into this branch: (the "0ms blocked" is an underapproximation) |
Contributor
|
@ANogin, should this PR be closed? |
Contributor
Author
|
Yes, I think this is not the way to go, unless/until there is some substantial changes of how things work in OFRAK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Use
aiofilesfor filesystem IOLink to Related Issue(s)
Please describe the changes in your request.
Replace blocking IO for file read/write with async io using
aiofilesAnyone you think should look at this, specifically?
Not sure