Fix an issue with parallel tests potentially clashing#468
Merged
whyitfor merged 2 commits intoJun 6, 2024
Conversation
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
…rity#468) * Fix an issue with parallel tests potentially clashing * Run pre-commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fix an issue with parallel tests potentially clashing
Link to Related Issue(s)
N/A
Please describe the changes in your request.
The
test_function_replacement_modifierinofrak/ofrak_core/test_ofrak/components/test_patch_maker_component.pyis configured to run several times, sometimes writing the samereplaced_hello.outprogram. When running tests in parallel, this can create spurious failures if two tests try to write the output binary at the same time. This change introduces an inter-process file lock to avoid this.Anyone you think should look at this, specifically?
Not sure