Do not run Ghidra auto-analysis on import#473
Merged
whyitfor merged 4 commits intoJun 7, 2024
Merged
Conversation
Member
|
Do not run. Do not run. (I'm gonna run.) |
whyitfor
reviewed
Jun 5, 2024
Contributor
|
Is the conditional analyzing performed by ghidra? i.e. the OFRAK user doesn't have to pass any new flags/call any new functions? If so, LGTM |
SamL98
approved these changes
Jun 7, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
* Prevent Ghidra autoanalysis on import * Update CHANGELOG.md * Add link to PR in changelog --------- Co-authored-by: Wyatt <53830972+whyitfor@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Link to Related Issue(s)
N/A
Please describe the changes in your request.
This change adds
-noanalysisto the import command in_do_ghidra_importin theGhidraProjectAnalyzer. Without this change, Ghidra analysis runs every time theGhidraProjectAnalyzerruns. This consumes a significant amount of time that is not necessary if using a pre-analyzed Ghidra project. By adding-noanalysisto the import command, the Ghidra analysis will run conditionally in_do_ghidra_analyze_and_serve, depending on if a pre-analyzed Ghidra project has been passed into the analyzer config.Anyone you think should look at this, specifically?
@whyitfor @SamL98