Make the log file name configurable and include timestamp by default#480
Merged
rbs-jacob merged 3 commits intoJul 9, 2024
Merged
Conversation
rbs-jacob
requested changes
Jul 9, 2024
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Change seems fairly straightforward and makes sense to me.
One thing I want to point out (for @whyitfor in particular) is that this changes a top-level API, and may necessitate a major version bump in OFRAK. The argument added to the OFRAK initializer is optional, so it shouldn't really break anything, nor should tha block this from being merged. Just wanted to highlight that we should bump semver on the next tagged release.
rbs-jacob
requested changes
Jul 9, 2024
Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
rbs-jacob
approved these changes
Jul 9, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
…edballoonsecurity#480) * Make the log file name configurable and include timestamp by default * Add a changelog entry * Fix a help string typo Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com> --------- Co-authored-by: Jacob Strieb <99368685+rbs-jacob@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
By default, the ofrak log is now
ofrak-YYYYMMDDhhmmss.lograther than justofrak.logand the name can be specified on the command line.Link to Related Issue(s)
#311
Please describe the changes in your request.
See summary
Anyone you think should look at this, specifically?
@whyitfor maybe?