Use temporary output directory for test_function_replacement_modifier#484
Merged
rbs-jacob merged 2 commits intoJul 17, 2024
Merged
Conversation
rbs-jacob
requested changes
Jul 17, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
…r` (redballoonsecurity#484) * Use temporary output directory for function replacement test * Use pathlib joining for file path
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently running the test suite (specifically
test_function_replacement_modifier) pollutes the current directory with these output files which the developer has to clean up to get a clean working tree. This changes it to use pytest'stmp_pathfixture.The output files from subsequent runs are saved in pytest's temporary directories like so instead of being overwritten: