Add SHELL instruction to avoid JSONArgsRecommended warning#489
Merged
Conversation
Contributor
|
Bit of an XY problem here. Why is |
Contributor
Author
I feel that |
rbs-jacob
approved these changes
Aug 16, 2024
ANogin
pushed a commit
to ANogin/ofrak
that referenced
this pull request
Aug 20, 2024
Add SHELL instruction to build_image.py to avoid JSONArgsRecommended warning
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Added
SHELLinstruction to image building script to ensure consistent OS signal behaviorLink to Related Issue(s)
N/A
Please describe the changes in your request.
As
build_image.pystands now, building images withENTRYPOINTs including&,&&, etc leads to the following warning in the build log forfinish.Dockerfile:WARN: JSONArgsRecommended: JSON arguments recommended for ENTRYPOINT to prevent unintended behavior related to OS signalsEg, when running
make tutorial-image:Or when building
ofrak-ghidra.yml(as it currently stands in master):As per the docs for this warning, one way to fix it is to pass the
ENTRYPOINTarguments in exec form, but this wouldn't work for ourofrak-ghidra, for example, because exec form would not allow&. The simpler way of fixing this warning be to explicitly define the shell to be/bin/bash, which this PR does by addingSHELL ["/bin/bash", "-c"]before theENTRYPOINT.Anyone you think should look at this, specifically?
N/A