Add a requirements.txt file to ofrak_angr#689
Open
ANogin wants to merge 3 commits into
Open
Conversation
4 tasks
Contributor
|
@claude Can you write a review with suggested comments here? |
|
Claude encountered an error —— View job I'll analyze this and get back to you. |
whyitfor
reviewed
Feb 4, 2026
| @@ -0,0 +1,7 @@ | |||
| angr==9.2.102; python_version == "3.9" | |||
Contributor
There was a problem hiding this comment.
Why is this different from 9.2.93? https://github.com/redballoonsecurity/ofrak/blob/master/disassemblers/ofrak_angr/setup.py#L30C10-L30C22
Contributor
Author
There was a problem hiding this comment.
@whyitfor to minimize the impact of the change, I picked the version that is the same as what was currently picked up - so this PR would not change what gets installed in containers built today. Not attached to that choice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Add a
requirements.txtfile for docker build optimizationLink to Related Issue(s)
N/A
Please describe the changes in your request.
All other modules have
requirements.txtthatbuild_image.pyuses for populatingbase.Dockerfile, butofrak_angrwas missing it.Anyone you think should look at this, specifically?
@whyitfor