Skip to content

Add a requirements.txt file to ofrak_angr#689

Open
ANogin wants to merge 3 commits into
redballoonsecurity:masterfrom
ANogin:maintenance/ofrak_angr_requirements_txt
Open

Add a requirements.txt file to ofrak_angr#689
ANogin wants to merge 3 commits into
redballoonsecurity:masterfrom
ANogin:maintenance/ofrak_angr_requirements_txt

Conversation

@ANogin
Copy link
Copy Markdown
Contributor

@ANogin ANogin commented Feb 1, 2026

  • I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
  • I have made or updated a changelog entry for the changes in this pull request.

One sentence summary of this PR (This should go in the CHANGELOG!)

Add a requirements.txt file for docker build optimization

Link to Related Issue(s)

N/A

Please describe the changes in your request.

All other modules have requirements.txt that build_image.py uses for populating base.Dockerfile, but ofrak_angr was missing it.

Anyone you think should look at this, specifically?

@whyitfor

@ANogin ANogin requested a review from whyitfor February 1, 2026 07:44
@ANogin ANogin self-assigned this Feb 1, 2026
@whyitfor
Copy link
Copy Markdown
Contributor

whyitfor commented Feb 2, 2026

@claude Can you write a review with suggested comments here?

@claude
Copy link
Copy Markdown

claude Bot commented Feb 2, 2026

Claude encountered an error —— View job

Command failed: git fetch origin --depth=20 maintenance/ofrak_angr_requirements_txt

I'll analyze this and get back to you.

@@ -0,0 +1,7 @@
angr==9.2.102; python_version == "3.9"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@whyitfor to minimize the impact of the change, I picked the version that is the same as what was currently picked up - so this PR would not change what gets installed in containers built today. Not attached to that choice.

@ANogin ANogin requested a review from whyitfor February 4, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants