Skip to content

Document CodeRegion requirement to be descendant of Program #696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ANogin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document CodeRegion requirement to be descendant of Program #696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ofrak_core/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)

### Fixed
- Fix `Resource.get_attributes` docstring to match implementation ([#692](https://github.com/redballoonsecurity/ofrak/pull/692))
- Document `CodeRegion` requirement to be descendant of `Program` for disassembly ([#696](https://github.com/redballoonsecurity/ofrak/pull/696))
- Fix GUI serialization of enum values and script creator generating invalid Python syntax for enum values
- `build_image.py` uses `OFRAK_DIR` from `extra_build_args` to identify `pytest_ofrak` location for develop builds ([#657](https://github.com/redballoonsecurity/ofrak/pull/657/))

Expand Down
3 changes: 3 additions & 0 deletions ofrak_core/src/ofrak/core/code_region.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@
class CodeRegion(MemoryRegion):
"""
A memory region within a [program][ofrak.core.program.Program] that contains executable code.

Must be a descendant of a Program for disassembly, as disassembler backends use the ancestor
Program to locate their analysis context.
"""


Expand Down
Loading