GUI vaddr search#70
Merged
rbs-jacob merged 14 commits intoOct 17, 2022
Merged
Conversation
…use Identify icon for search button
rbs-jacob
requested changes
Oct 10, 2022
Member
rbs-jacob
left a comment
rbs-jacob
left a comment
There was a problem hiding this comment.
Looks good! Very minor changes recommended.
rbs-jacob
approved these changes
Oct 17, 2022
EdwardLarson
pushed a commit
to EdwardLarson/ofrak
that referenced
this pull request
Aug 8, 2023
…ct-tests Feature/project tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to Related Issue(s)
N/A
Please describe the changes in your request.
Adds a search functionality in the GUI, accessed from the toolbar. With a resource selected, one can search its descendants for resources with a
VirtualAddressmatching a specific value or within a range. These are displayed in the search view; each one can be selected as usual, and after going back to the main view, it remains selected.Anyone you think should look at this, specifically?
@rbs-jacob