Fix mypy errors in pytest_ofrak and enforce it in CI#703
Open
ANogin wants to merge 2 commits into
Open
Conversation
- Add mypy.ini and `make inspect` target to run mypy - Fix type annotations: return types, async methods, generic parameters - Only generate `make test` targets in develop builds (where pytest_ofrak is installed) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Workaround for python/mypy#12633, fixed in mypy 0.950. Explicit type redeclarations in subclasses can be removed once using a newer mypy. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ANogin
pushed a commit
that referenced
this pull request
Feb 8, 2026
ANogin
pushed a commit
that referenced
this pull request
Feb 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Fix mypy type errors across the package
Link to Related Issue(s)
N/A
Please describe the changes in your request.
make inspecttarget to run mypymake testrootMakefiletarget in develop builds (wherepytest_ofrakis installed), and include$(MAKE) -C pytest_ofrak inspectin itAnyone you think should look at this, specifically?
Not sure, @whyitfor should probably decide