Use tmp_path for ELF test output artifacts instead of source tree#705
Open
ANogin wants to merge 1 commit into
Open
Use tmp_path for ELF test output artifacts instead of source tree#705ANogin wants to merge 1 commit into
tmp_path for ELF test output artifacts instead of source tree#705ANogin wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Use
tmp_pathfor ELF test output artifacts instead of source treeLink to Related Issue(s)
N/A
Please describe the changes in your request.
The current test implementation uses
tmp_pathfor some generated artifacts, but not for all - and those in-tree generated artifacts are not even gitignored, resulting in bogusgit statuspollution. This makes suretmp_pathis consistently usedAnyone you think should look at this, specifically?
@whyitfor