Remove the Identify button from OFRAK GUI#731
Open
AndreQuimper wants to merge 3 commits into
Open
Conversation
Author
|
It seems like the CI is failing because it is trying to run wget on |
Member
|
Seems to have been fixed here: #733 I'll review that PR and probably merge soon. |
Member
|
Seems like CI is passing on I like the idea behind this change, but will have to review the code to make sure it's the ideal way to implement this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: these changes only apply to files under
frontend/, which does not maintain a changelogOne sentence summary of this PR (This should go in the CHANGELOG!)
Identify button was removed from toolbar, now
identify()is ran on a resource automatically when it is selected in the GUI.Link to Related Issue(s)
#635
Please describe the changes in your request.
When exploring resources in the OFRAK GUI, when a resource is clicked or otherwise selected, identifiers automatically run against that resource and the resource's captions and ResourceTags get updated automatically. Because of this, the "Identify" button is no longer needed.
Given that the initial issue had some concerns about this change negatively impacting the responsiveness of the GUI I decided to run some manual benchmarking. I used a RPI5 squashfs Image from openwrt. Benchmarking showed an average delay of 115ms (worst case 758.8 ms when running identify on the top level image) per resource selection to identify and update the frontend. Due to the asynchronous nature of the UI and the fact that other things (such as the hex view) also update when you select a new resource, this was not noticeable in my opinion. Additionally, OFRAK does not re-run identifiers on resources that have already been identified. If we find this delay unacceptable, I could pivot to merging the "identify" and "unpack" buttons, as mentioned in the issue.
Anyone you think should look at this, specifically?
@whyitfor