Skip to content

Remove the Identify button from OFRAK GUI#731

Open
AndreQuimper wants to merge 3 commits into
redballoonsecurity:masterfrom
AndreQuimper:maintenance/635-gui-auto-identify
Open

Remove the Identify button from OFRAK GUI#731
AndreQuimper wants to merge 3 commits into
redballoonsecurity:masterfrom
AndreQuimper:maintenance/635-gui-auto-identify

Conversation

@AndreQuimper
Copy link
Copy Markdown

  • I have reviewed the OFRAK contributor guide and attest that this pull request is in accordance with it.
  • I have made or updated a changelog entry for the changes in this pull request.

Note: these changes only apply to files under frontend/, which does not maintain a changelog

One sentence summary of this PR (This should go in the CHANGELOG!)
Identify button was removed from toolbar, now identify() is ran on a resource automatically when it is selected in the GUI.

Link to Related Issue(s)
#635

Please describe the changes in your request.
When exploring resources in the OFRAK GUI, when a resource is clicked or otherwise selected, identifiers automatically run against that resource and the resource's captions and ResourceTags get updated automatically. Because of this, the "Identify" button is no longer needed.

Given that the initial issue had some concerns about this change negatively impacting the responsiveness of the GUI I decided to run some manual benchmarking. I used a RPI5 squashfs Image from openwrt. Benchmarking showed an average delay of 115ms (worst case 758.8 ms when running identify on the top level image) per resource selection to identify and update the frontend. Due to the asynchronous nature of the UI and the fact that other things (such as the hex view) also update when you select a new resource, this was not noticeable in my opinion. Additionally, OFRAK does not re-run identifiers on resources that have already been identified. If we find this delay unacceptable, I could pivot to merging the "identify" and "unpack" buttons, as mentioned in the issue.

Anyone you think should look at this, specifically?
@whyitfor

@AndreQuimper
Copy link
Copy Markdown
Author

AndreQuimper commented Apr 8, 2026

It seems like the CI is failing because it is trying to run wget on https://www.7-zip.org/a/7z2201-linux-x64.tar.xz, but that link is dead.
See for example: test OFRAK angr and capstone components

@rbs-jacob
Copy link
Copy Markdown
Member

Seems to have been fixed here: #733

I'll review that PR and probably merge soon.

@rbs-jacob
Copy link
Copy Markdown
Member

Seems like CI is passing on master, and that branch should be merged into this one to get CI to pass.

I like the idea behind this change, but will have to review the code to make sure it's the ideal way to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants