Draft: Speed up SegmentInjectorModifier#746
Open
rbs-afflitto wants to merge 2 commits into
Open
Conversation
rbs-afflitto
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One sentence summary of this PR (This should go in the CHANGELOG!)
Optimize SegmentInjectorModifier for bulk segment injection
Link to Related Issue(s)
n/a
Please describe the changes in your request.
This PR optimizes SegmentInjectorModifier. Instead of running BinaryInjectorModifier separately for each segment, it collects all segment patches and applies them in a single bulk queue_patch operation. Stale descendants are now identified proactively by checking which resources have data ranges (within root) that overlap the patch ranges, rather than reactively tracking which resources were modified by each BinaryInjectorModifier call.
Closes #685.
Anyone you think should look at this, specifically?
@whyitfor